Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gen 2] adds Kore Vodafone SIM support & removes Twilio SIM support (… #1780

Merged
merged 1 commit into from May 16, 2019

Conversation

@technobly
Copy link
Member

commented May 16, 2019

…still supported through 3rd party API) [ch31955]

Problem

  • Kore Vodafone SIM not supported in system firmware for Gen 2 devices
  • 3rd Party Twilio SIM users were having issues with system firmware taking over and using port 4500

Solution

  • Add Kore Vodafone SIM support via IMSI lookup & matching
  • Remove Twilio SIM support (still supported through 3rd party API)

Steps to Test

  • Run unit tests
  • Run included test app on:
    • E Series U201 with Kore Vodafone embedded SIM
    • Electron U260 with Kore Vodafone 4FF Nano SIM
    • Electron G350 with Kore Vodafone 4FF Nano SIM
    • E Series R410 with Kore AT&T embedded SIM
    • Electron U260 with Kore Telefonica 4FF Nano SIM
    • Electron U260 with Kore Telefonica 4FF Nano SIM and 3rd party API
    • Electron U260 with Twilio 4FF Nano SIM and 3rd party API
  • Tested Particle.keepAlive() worked up to 29 minutes with Kore Vodafone without UDP NAT timeout (might go further)

Example App

#include "Particle.h"

SYSTEM_MODE(SEMI_AUTOMATIC)

// STARTUP(cellular_credentials_set("10569.mcs", "", "", NULL)); // KORE - AT&T
// STARTUP(cellular_credentials_set("vfd1.korem2m.com", "", "", NULL)); // KORE - vodaphone
// STARTUP(cellular_credentials_set("spark.telefonica.com", "", "", NULL)); // telefonica
// STARTUP(cellular_credentials_set("wireless.twilio.com", "", "", NULL)); // twilio

SerialLogHandler logHandler(115200, LOG_LEVEL_TRACE);

String variableString;
bool publishNow = false;

int setString(String data)
{
    variableString = data;
    publishNow = true;
    return variableString.length();
}

void setup() {
    while (!Serial.isConnected()) Particle.process();
    Particle.keepAlive(29*60);
    variableString.reserve(622);
    Particle.variable("string", variableString);
    Particle.function("set", setString);
    Particle.connect();
}

void loop() {
    if (Particle.connected() && publishNow) {
        publishNow = false;
        Log.info("========= PUBLISHING =========");
        Particle.publish("string", variableString, PRIVATE, WITH_ACK);
    }
}

References

Closes [ch31955]


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • N/A Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [enhancement] [gen 2] adds Kore Vodafone SIM support & removes Twilio SIM support (still supported through 3rd party API) [ch31955] #1780

@technobly technobly added this to the 1.2.0-rc.1 milestone May 16, 2019

@technobly technobly requested a review from sergeuz May 16, 2019

hal/inc/cellular_hal_constants.h Outdated Show resolved Hide resolved

@m-mcgowan m-mcgowan removed the needs review label May 16, 2019

[gen 2] adds Kore Vodafone SIM support & removes Twilio SIM support (…
…still supported through 3rd party API) [ch31955]

@technobly technobly force-pushed the ch31955/vodafone branch from 81dea83 to 7e555f9 May 16, 2019

@technobly technobly merged commit 30a63c9 into develop May 16, 2019

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the ch31955/vodafone branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.