Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Photon / P1] Fixes MAC address info not being available in listening mode #1783

Merged
merged 1 commit into from May 16, 2019

Conversation

@avtolstoy
Copy link
Member

commented May 16, 2019

Problem

#1781

This is an artifact of Gen 2 / Gen 3 merge where we've changed the behavior of listening mode: it's no longer blocking and is a part of the system loop. This causes network config to be zeroed out by manage_ip_config() -> update_config().

Solution

A simplest fix is probably just force-filling the configuration in the API network_config() call.

Steps to Test

Put your Photon into listening mode, call particle serial mac. The MAC address should be available.

Example App

N/A

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [bugfix] [Photon/P1] Fixes MAC address info not being available in listening mode #1783

@avtolstoy avtolstoy added this to the 1.2.0-rc.1 milestone May 16, 2019

@avtolstoy avtolstoy requested review from m-mcgowan and technobly May 16, 2019

@technobly technobly force-pushed the fix/gen2-mac-address-listening-mode branch from ca8d182 to f4fe7cb May 16, 2019

@technobly technobly merged commit 082f07c into develop May 16, 2019

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/gen2-mac-address-listening-mode branch May 16, 2019

@technobly technobly removed the request for review from m-mcgowan May 16, 2019

@incorvia

This comment has been minimized.

Copy link

commented May 30, 2019

Is there anywhere I can read more information about this comment: "we've changed the behavior of listening mode: it's no longer blocking and is a part of the system loop".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.