Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gen 2] Fix ABI compatibility issue in cellular HAL #1792

Merged
merged 3 commits into from May 29, 2019

Conversation

@sergeuz
Copy link
Member

commented May 24, 2019

Before merging, let's figure out which release branches we want to apply this to.

  • develop only at this time (will be picked up in 1.2.1-rc.1 and subsequently 1.3.0-alpha.1 when it is rebased on 1.2.1-rc.1)

Problem

This PR fixes the ABI compatibility issue in the cellular HAL, which was introduced in 1df0c18#diff-7a8d5f66bffd6a68cd5013b3f8709506R171 – this commit adds a new field to the CellularDevice structure but is missing necessary structure size checks to preserve the backward compatibility.

References

  • [ch32823]

  • [bugfix] [gen 2] Fix ABI compatibility issue in cellular HAL regarding CellularDevice and cellular_device_info() #1792

@sergeuz sergeuz added the bug label May 24, 2019

@sergeuz sergeuz requested a review from technobly May 24, 2019

@technobly technobly force-pushed the fix/cellular_hal_abi branch from 2dcac77 to e73c407 May 29, 2019

@technobly technobly added this to the 1.2.1-rc.2 milestone May 29, 2019

@technobly technobly merged commit b0070e8 into develop May 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@technobly technobly deleted the fix/cellular_hal_abi branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.