Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache cellular diagnostics #1810

Merged
merged 4 commits into from Jun 11, 2019

Conversation

@zfields
Copy link
Contributor

commented Jun 7, 2019

Problem

Current implementation requires multiple calls to AT+COPS and could result in an inconsistent cellular global identity.

Solution

By caching the diagnostic results we only check every 1 second.

Steps to Test

Watch the modem logs.

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [enhancement] Cache cellular diagnostics #1810

@zfields zfields added the enhancement label Jun 7, 2019

@zfields zfields added this to the 1.2.1-rc.2 milestone Jun 7, 2019

@zfields zfields requested review from avtolstoy and technobly Jun 7, 2019

@zfields zfields self-assigned this Jun 7, 2019

system/src/system_network_diagnostics.cpp Outdated Show resolved Hide resolved

@zfields zfields requested review from avtolstoy and technobly Jun 9, 2019

@zfields zfields force-pushed the cgi-cache branch from 7b95362 to 6570a71 Jun 9, 2019

@technobly technobly modified the milestones: 1.2.1-rc.2, 1.3.0-beta.1 Jun 9, 2019

@technobly technobly modified the milestones: 1.3.0-beta.1, 1.2.1 Jun 10, 2019

@zfields zfields force-pushed the cgi-cache branch from 6570a71 to 0f045c5 Jun 10, 2019

system/src/system_network_diagnostics.cpp Outdated Show resolved Hide resolved

@zfields zfields merged commit 808e4a7 into develop Jun 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zfields zfields deleted the cgi-cache branch Jun 11, 2019

@technobly technobly removed this from the 1.2.1 milestone Jun 12, 2019

@technobly technobly added this to the 1.3.0-rc.1 milestone Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.