Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lte] cellular fixes #1824

Merged
merged 6 commits into from Jun 14, 2019

Conversation

@technobly
Copy link
Member

commented Jun 13, 2019

This PR will be cherry-picked into 2 more PRs that will be based on release/1.2.1 (for 1.2.1-rc.3) and release/1.1.0 (for 1.1.1-rc.1 for a Gen 2 manufacturing release).

Problem

There are several issues currently:

  • u-blox SARA-R410M-02B firmware 05.06,A.02.00 has a memory housekeeping issue where after every 124 days it does a cleanup. If the power is forced off while that cleanup is in progress, the modem can enter an unrecoverable state. u-blox has advised on proper timeouts from power up and registration to mitigate this issue. Only this particular version of u-blox firmware has this issue.
  • u-blox SARA-R410M-02B firmware 05.08,A.02.04 changes the way some line endings are generated for multiple commands. This breaks the AT command parser on Gen 2 devices. Gen 3 is unaffected based on how it removes all line endings before parsing commands.
  • u-blox SARA-R410M-02B firmware 05.08,A.02.04 requires the AT+UMNOPROF default setting to be changed to a specific carrier, or SIM Select. We prefer SIM Select as it should allow 3rd party SIMs to have the correct settings applied.

Solution

This PR solves the above issues by implementing a commit for each one:

  • [gen 2] mitigates memory issue in u-blox firmware 05.06,A.02.00 [ch33464]
  • [gen 2] fixes AT command parser issues with u-blox firmware 05.08,A.02.04 [ch32049]
  • [gen 2] adds AT+UMNOPROF=1 (SIM Select) setting [ch29063]
  • [gen 2] adds debugging for Pipe buffer with MDM_DEBUG_RX_PIPE & MDM_DEBUG_TX_PIPE defines
  • [gen 3] mitigates memory issue in u-blox firmware 05.06,A.02.00 [ch33464]
  • [gen 3] adds AT+UMNOPROF=1 (SIM Select) setting [ch29063]

Steps to Test

  • Run unit tests
  • Run TEST=wiring/no_fixture
  • Lots of manual testing on U260, G350, R410 modems with new and old u-blox firmware

References

Closes [ch33464]
Closes [ch32049]
Closes [ch29063]


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • (N/A) Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [bugfix] [lte] cellular fixes #1824

@technobly technobly added this to the 1.3.0-rc.1 milestone Jun 13, 2019

@technobly technobly force-pushed the fix/lte-issues branch from a47aeed to c6db6dd Jun 13, 2019

@technobly technobly requested review from avtolstoy and sergeuz Jun 14, 2019

@technobly technobly added needs review and removed in progress labels Jun 14, 2019

hal/src/boron/network/cellular_ncp_client.h Outdated Show resolved Hide resolved
hal/src/boron/network/sara_ncp_client.cpp Outdated Show resolved Hide resolved
hal/src/electron/modem/enums_hal.h Outdated Show resolved Hide resolved
hal/src/boron/network/sara_ncp_client.cpp Outdated Show resolved Hide resolved
hal/src/electron/modem/mdm_hal.cpp Outdated Show resolved Hide resolved

@technobly technobly force-pushed the fix/lte-issues branch from f6e446f to 1e27728 Jun 14, 2019

@technobly technobly force-pushed the fix/lte-issues branch from 1e27728 to 7ed4bbe Jun 14, 2019

@technobly technobly removed the request for review from sergeuz Jun 14, 2019

@technobly technobly merged commit 0463cd1 into develop Jun 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@technobly technobly deleted the fix/lte-issues branch Jun 14, 2019

@technobly technobly removed the enhancement label Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.