Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Rework pinmap for each platforms #1838
We use conditional compilation to reuse the pin definition which makes our pinmap messy. The pin definition should be moved to platform-specific implementation headers.
Steps to Test
The old pin definition is fragmented, if you want to review the pin definition, you can utilize VSCode highlight function by adding two lines platform definition to compare.
Will this break a lot of library usage of these functions? I would argue this is our public API for low level pin usage, so if it will break things this should be deprecated in 1.x.x and removed only in 2.x.x. We would also need to fix the warnings being seen in the web IDE.