Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

communications public interface #1863

Merged
merged 2 commits into from Aug 1, 2019

Conversation

@m-mcgowan
Copy link
Contributor

commented Jul 25, 2019

Problem

The internal and public headers were contained in the src folder which was exported as the public interface, exporting internal headers at the same time.

Solution

Add an inc folder that contains the public headers while keeping the private headers in the src folder.

Steps to Test

Build all platforms.


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [internal] fixes to communications public interface #1863

@m-mcgowan m-mcgowan requested a review from zfields Jul 25, 2019

@zfields zfields force-pushed the feature/communications_include_folder branch 2 times, most recently from b994058 to 5a78cf8 Jul 26, 2019

@m-mcgowan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

In chatting with @zfields he asked me to not fix the failing build since he's working on a PR based on this where he will fix up the include path since it's in code that is changing.

@zfields zfields force-pushed the feature/communications_include_folder branch 2 times, most recently from 6bc198f to c8c36fa Aug 1, 2019

@zfields zfields self-assigned this Aug 1, 2019

@zfields zfields requested review from technobly and removed request for zfields Aug 1, 2019

@zfields zfields added this to the 1.3.1-rc.1 milestone Aug 1, 2019

@zfields zfields requested review from zfields and removed request for zfields Aug 1, 2019

@zfields
zfields approved these changes Aug 1, 2019

@zfields zfields self-requested a review Aug 1, 2019

@zfields zfields added ready to merge and removed needs review labels Aug 1, 2019

m-mcgowan and others added 2 commits Jul 25, 2019
Update tests
Update include path in Makefiles
Include coverage summary in Travis CI

@zfields zfields force-pushed the feature/communications_include_folder branch from c8c36fa to 32547ce Aug 1, 2019

@zfields
zfields approved these changes Aug 1, 2019

@zfields zfields merged commit 6c5e377 into develop Aug 1, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zfields zfields deleted the feature/communications_include_folder branch Aug 1, 2019

@technobly technobly removed their request for review Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.