Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull test implementation out of source file #1867

Merged
merged 1 commit into from Jul 29, 2019

Conversation

@zfields
Copy link
Contributor

commented Jul 29, 2019

Remove test implementation from source
**Important:** Please sanitize/remove any confidential info like usernames, passwords, org names, product names/ids, access tokens, client ids/secrets, or anything else you don't wish to share.

Please Read and Sign the Contributor License Agreement ([Info here](https://github.com/spark/firmware/blob/develop/CONTRIBUTING.md)).

You may also delete this submission notes header if you'd like. Thank you for contributing!

Problem

Test code should not exist in our production code base

Solution

Migrate test code from source to test file.

Steps to Test

Compile Catch2 unit-tests.

Example App

cd <particle-iot/device-os>/test/unit_tests/
rm -rf .build/ && mkdir .build && cd .build/
cmake ..
make all test coverage

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [internal] Pull test implementation out of source file #1867

@zfields zfields added the enhancement label Jul 29, 2019

@zfields zfields self-assigned this Jul 29, 2019

@zfields zfields requested a review from technobly Jul 29, 2019

@zfields zfields force-pushed the refactor/publish-test branch from a54147f to 0d7c672 Jul 29, 2019

@zfields zfields force-pushed the refactor/publish-test branch from 0d7c672 to ba0b0ba Jul 29, 2019

@zfields zfields requested a review from m-mcgowan Jul 29, 2019

@zfields zfields merged commit 92aa4c6 into develop Jul 29, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zfields zfields removed the needs review label Jul 29, 2019

@zfields zfields deleted the refactor/publish-test branch Jul 29, 2019

@technobly technobly added internal and removed enhancement labels Aug 20, 2019

@technobly technobly removed their request for review Aug 20, 2019

@technobly technobly added this to the 1.3.1-rc.1 milestone Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.