Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/move catch test #1869

Merged
merged 3 commits into from Aug 1, 2019

Conversation

@zfields
Copy link
Contributor

commented Jul 31, 2019

submission notes ``` Migrating Catch2 tests into `/test/unit_tests/` to build using CMake and include in coverage statistics. ```

Problem

Coverage statistics are not being captured with unit-tests.

Solution

Increases coverage, moves Catch2 tests to common directory.

Steps to Test

TravisCI build confirms the solution

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [internal] Refactor/move catch test #1869

@zfields zfields requested a review from m-mcgowan Jul 31, 2019

@zfields zfields force-pushed the refactor/move-catch-test branch 10 times, most recently from 6bf275c to 895a84c Jul 31, 2019

@zfields zfields force-pushed the refactor/move-catch-test branch from 895a84c to dc8d915 Aug 1, 2019

@zfields zfields added this to the 1.3.1-rc.1 milestone Aug 1, 2019

@zfields zfields self-assigned this Aug 1, 2019

@zfields zfields merged commit cf898e7 into develop Aug 1, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zfields zfields deleted the refactor/move-catch-test branch Aug 1, 2019

@technobly technobly added internal and removed enhancement labels Aug 1, 2019

@sergeuz sergeuz restored the refactor/move-catch-test branch Aug 2, 2019

@sergeuz sergeuz deleted the refactor/move-catch-test branch Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.