Set path to Boost libraries #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zfields
previously requested changes
Aug 2, 2019
zfields
reviewed
Aug 3, 2019
| find_package(Boost | ||
| 1.59.0 EXACT | ||
| REQUIRED | ||
| COMPONENTS program_options random regex system thread |
There was a problem hiding this comment.
@sergeuz I put random in this list because of <particle-iot/device-os>/ci/build_boost.sh, but based on the list in your first PR, we may not need to check for it.
|
@zfields The boost path changes work like a charm, thank you! I enabled multithreading support in Boost – not sure why we were building it in single-threaded mode |
sergeuz
commented
Aug 3, 2019
| @@ -10,7 +10,6 @@ if contains "${BUILD_PLATFORM[*]}" unit-test; then | |||
| ( source ./ci/install_gcovr.sh | |||
| source ./ci/install_boost.sh | |||
| ./ci/build_boost.sh && | |||
| cp -r ${BOOST_ROOT}/boost/ /usr/include/ && | |||
avtolstoy
approved these changes
Aug 3, 2019
sergeuz
dismissed
zfields’s stale review
The requested changes have been addressed by the requester :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is now required to have Boost libraries installed globally in the system to build CMake-based unit tests locally (this change was introduced in #1869). This PR changes the paths to Boost libraries back to
$BOOST_ROOTwhich is set by CI scripts.Note: This is a temporary solution. Ideally, we'd want all necessary paths to be detected and set using built-in CMake mechanisms.
Steps to Test
source ci/install_boost.sh.ci/build_boost.sh.