Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gcc] fixes virtual platform exception on startup #1878 [ch35243] #1878

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@m-mcgowan
Copy link
Contributor

commented Aug 5, 2019

submission notes

Problem

The Gen2 virtual platform failed on startup due to a coding error.

Solution

Fix the coding error. This was clearly a remnant from early thoughts on the code design.

Steps to Test

Start the executable produced when building platform 3.

Note that I was unable to test this since the cross compile build was not working on my system.

Reference

Closes #1842


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [bugfix] [gcc] fixes virtual platform exception on startup #1878

@technobly technobly added this to the 1.3.1-rc.1 milestone Aug 20, 2019

@technobly technobly added the bug label Aug 20, 2019

@technobly technobly force-pushed the fix/ch35243 branch from 2b42fd3 to 0f889f5 Aug 20, 2019

@technobly
Copy link
Member

left a comment

Approved under the reasoning that it is the same implementation for the Core, which is to say it's just stubbing out this function to have no affect.

@technobly technobly changed the title fixes ch35243, issue #1842 [gcc] fixes virtual platform exception on startup #1878 [ch35243] Aug 20, 2019

@technobly technobly merged commit ed8030e into develop Aug 20, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@technobly technobly deleted the fix/ch35243 branch Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.