Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hal] Fixes WIFIEN pin mode for ASoM #1889

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@YutingYou
Copy link
Contributor

commented Aug 21, 2019

Problem

ASOM has a pull-down resistor on ESPEN pin, it's different from ARGON, so the pin mode should be output drain on ARGON, output on ASOM.

Solution

Fix the pin mode.

Steps to Test

Connect ARGON and ASOM to the cloud.

Test result: Passed.

Example App

N/A

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [bugfix] [hal] Fixes WIFIEN pin mode for ASoM #1889

@YutingYou YutingYou requested a review from avtolstoy Aug 21, 2019

@technobly technobly added this to the 1.3.1-rc.1 milestone Aug 21, 2019

@technobly technobly added the bug label Aug 21, 2019

@technobly technobly removed this from the 1.3.1-rc.1 milestone Aug 21, 2019

@technobly technobly added this to the 1.3.1-rc.1 milestone Aug 21, 2019

@technobly technobly merged commit 1c9a402 into develop Aug 21, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/asom-wifien-pin-mode branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.