Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: minor fixes #1891

Merged
merged 6 commits into from Aug 26, 2019

Conversation

@XuGuohui
Copy link
Contributor

commented Aug 22, 2019

Bugfixes

  • Restored default BLE device address is incorrect.
  • Read BLE device name might be contracted.
  • operator& of the BleCharacteristicProperty enum class doesn't work as expected.
  • The length of got advertising and scan response data is not updated.

@XuGuohui XuGuohui requested a review from avtolstoy Aug 22, 2019

@avtolstoy avtolstoy added this to the 1.4.0 milestone Aug 22, 2019

@XuGuohui XuGuohui removed the in progress label Aug 23, 2019

hal/src/nRF52840/ble_hal.cpp Outdated Show resolved Hide resolved
hal/src/nRF52840/ble_hal.cpp Show resolved Hide resolved
wiring/src/spark_wiring_ble.cpp Outdated Show resolved Hide resolved
@avtolstoy

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Please also indicate any GH issues this PR closes.

@avtolstoy avtolstoy modified the milestones: 1.4.0, 1.4.0-rc.1 Aug 23, 2019

@XuGuohui XuGuohui requested a review from avtolstoy Aug 23, 2019

hal/src/nRF52840/ble_hal.cpp Outdated Show resolved Hide resolved

@XuGuohui XuGuohui force-pushed the fix/ble_minor_fixes branch from 4ae4ef7 to 929e558 Aug 23, 2019

@XuGuohui XuGuohui force-pushed the fix/ble_minor_fixes branch from 929e558 to 6d860c7 Aug 26, 2019

@XuGuohui XuGuohui merged commit ae42671 into develop Aug 26, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@XuGuohui XuGuohui deleted the fix/ble_minor_fixes branch Aug 26, 2019

@XuGuohui

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

Fixes #1888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.