Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[user] fixes weird alignment error with the dynalib table location #1894

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@avtolstoy
Copy link
Member

commented Aug 23, 2019

Problem

Closes #1843

Solution

Putting the dynalib into a separate section in the linker file seems to help.

Steps to Test

Build the test application from #1843. It should build without linker errors.

Example App

N/A

References


Changelog

  • [bugfix] [Gen2 / Gen3] Fixes dynalib alignment issue when compiling relatively large applications potentially due to an unconfirmed bug in GCC by moving the dynalib into a separate section (.dynalib)

@avtolstoy avtolstoy added this to the 1.4.0-rc.1 milestone Aug 23, 2019

@avtolstoy avtolstoy requested a review from XuGuohui Aug 23, 2019

@m-mcgowan m-mcgowan self-requested a review Aug 23, 2019

@avtolstoy avtolstoy force-pushed the fix/linker-file-dynalib-weirdness branch from a67fa16 to 3be6bc9 Aug 26, 2019

@avtolstoy avtolstoy merged commit f98e286 into develop Aug 26, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@avtolstoy avtolstoy deleted the fix/linker-file-dynalib-weirdness branch Aug 26, 2019

@avtolstoy avtolstoy referenced this pull request Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.