Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose select() and poll() to apps #1895

Merged
merged 7 commits into from Aug 29, 2019

Conversation

@larseggert
Copy link
Contributor

commented Aug 27, 2019

Problem

select and poll system calls are not exposed to applications

Solution

Patch exposes select and poll via dynalib


Changelog

  • [feature] [Gen 3] Exposes POSIX select() and poll() from socket HAL dynalib
larseggert added 3 commits Aug 1, 2019
@avtolstoy
Copy link
Member

left a comment

Thanks for submitting the PR!

hal/inc/socket_hal_posix.h Outdated Show resolved Hide resolved
hal/inc/socket_hal_posix.h Show resolved Hide resolved
hal/inc/socket_hal_posix.h Outdated Show resolved Hide resolved
hal/network/lwip/socket_hal.cpp Outdated Show resolved Hide resolved
larseggert added 4 commits Aug 27, 2019
@larseggert

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

@avtolstoy I think I addressed your review comments

@avtolstoy avtolstoy modified the milestones: 1.5.0, 1.4.0 Aug 28, 2019

@avtolstoy

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

@larseggert I've approved and scheduled this for 1.4.0. One last suggestion I'd make is to perhaps remove empty merge commits (ed6d364 and fde938f) if possible in order to keep the history clean.

@avtolstoy avtolstoy merged commit 38d5a2e into particle-iot:develop Aug 29, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@avtolstoy avtolstoy modified the milestones: 1.4.0, 1.4.0-rc.1 Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.