Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis CI for Coveralls #1896

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@zfields
Copy link
Contributor

commented Aug 28, 2019

Problem

Travis CI is not integrated with Coveralls

Solution

Update scripts, called by Travis CI, to generate Coveralls formatted coverage JSON, and submit the results to Coveralls.

Steps to Test

Run Travis CI, and see if the coverage results appear in Coveralls

References

Coveralls
Travis CI


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@zfields zfields added this to the 1.3.1 milestone Aug 28, 2019

@zfields zfields self-assigned this Aug 28, 2019

@zfields zfields force-pushed the ci branch 4 times, most recently from 0d42d0e to 1a53285 Aug 28, 2019

@m-mcgowan m-mcgowan self-requested a review Aug 28, 2019

@m-mcgowan
Copy link
Contributor

left a comment

Looks great! Does this inform coveralls which branch is being covered?

if [ "${KERNEL_NAME}" == "Darwin" ]; then
brew install gcovr || exit 1
brew install --force git python || exit 1

This comment has been minimized.

Copy link
@m-mcgowan

m-mcgowan Aug 28, 2019

Contributor

why do we need --force? some comments would be useful

This comment has been minimized.

Copy link
@zfields

zfields Aug 28, 2019

Author Contributor

We don't: I'll pull it.

An update available for git was causing a fatal error in the script. I thought --force would ignore the error, but it did not. I ended up updating git on the target to make it work, and I forgot to remove --force.

Is there a proper brew install flag to ignore updates?

@zfields zfields force-pushed the ci branch 10 times, most recently from dfe2077 to a8a2b7b Aug 28, 2019

@zfields zfields removed the do not merge label Aug 30, 2019

@zfields zfields requested a review from m-mcgowan Aug 30, 2019

@m-mcgowan
Copy link
Contributor

left a comment

Bravo! just a few questions and suggestions in the comments.


# Install custom `gcovr` to support Coveralls output
pushd ~
git clone https://github.com/zfields/gcovr.git -b coveralls

This comment has been minimized.

Copy link
@m-mcgowan

m-mcgowan Aug 30, 2019

Contributor

I think it's normally best to keep device-os dependencies in a particle repo when we can. I realize your PR may be merged into the main gcovr repo, so we'll leave this as is for now. I've set myself a reminder to check back about this in 1 month.

@@ -0,0 +1,104 @@
#!/usr/bin/env python

This comment has been minimized.

Copy link
@m-mcgowan

m-mcgowan Aug 30, 2019

Contributor

Should this code have a particle copyright notice?

This comment has been minimized.

Copy link
@zfields

zfields Aug 30, 2019

Author Contributor

It's not ours. I made improvements to make it work with Travis CI, but the original work is borrowed from the cpp-coveralls project.

I put it in it's own folder, along with it's LICENSE agreement, APL2.0, to highlight this fact.

This comment has been minimized.

Copy link
@m-mcgowan

m-mcgowan Aug 30, 2019

Contributor

ok, thanks for clarifying!

@@ -0,0 +1,104 @@
#!/usr/bin/env python

This comment has been minimized.

Copy link
@m-mcgowan

m-mcgowan Aug 30, 2019

Contributor

ok, thanks for clarifying!

@zfields zfields merged commit be5bf85 into develop Aug 30, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on ci at 42.476%
Details

@zfields zfields deleted the ci branch Aug 30, 2019

@zfields zfields removed the needs review label Aug 30, 2019

@avtolstoy avtolstoy modified the milestones: 1.3.1, 1.4.0-rc.1 Aug 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.