Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues encountered during 1.4.0 rc.1 testing #1898

merged 11 commits into from Aug 30, 2019


Copy link

commented Aug 30, 2019


This PR:

  1. CRITICAL: Fixes session resume broken after an upgrade of MbedTLS. One of the internal fields in the mbedtls_ssl_context changed its meaning.
  2. MbedTLS logging was not re-enabled on all the platforms. #define MBEDTLS_DEBUG_C was added to platform configs where it was commented out.
  3. Fixes CellularSignal rssi and qual compatibility with Gen 2 on Gen 3 platforms. Fixes CELLULAR_07_rssi_is_valid test
  4. Removes a rogue $(error) call in tinker makefile when building with LOG_SERIAL=y
  5. CRITICAL: fixes heap and application static RAM overlap. This was the cause of SYSTEM_07_fragmented_heap stress test failure and who knows how many of the other weird Gen 3 issues. This needs be backported into 1.3.1 default as we broke things in 1.3.0-rc.1 in #1819
  6. MDM_01_socket_writes_with_length_more_than_1023_work_correctly, MDM_02_at_commands_with_long_response_are_correctly_parsed_and_flow_controlled enabled for non-LTE Gen 3 devices. MDM_03_restore_cloud_connections added
  7. MESH_01_PublishWithoutSubscribeStillReadsDataOutOfPubSubSocket is automatically skipped if there are no Mesh credentials on the device
  8. Relaxes APPLICATION_WATCHDOG_02_doesnt_fire_when_app_checks_in and APPLICATION_WATCHDOG_03_doesnt_leak_memory slightly
  9. Strengthens SYSTEM_07_fragmented_heap to also fill the allocated blocks with random data to more easily indicate potential issues with heap/static RAM overlap and heap corruptions.
  10. Adds SYSTEM_09_out_of_memory_restore_state test.
  11. Disconnects cloud and network during PWM tests
  12. Removes DNS and DHCP server checks in WIFI_04_config for Gen 3 devices

Steps to Test

Run wiring/no_fixture on Gen 2 and Gen 3 platforms.

Example App





  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to after merging (add links to docs and issues)

@avtolstoy avtolstoy added this to the 1.4.0-rc.1 milestone Aug 30, 2019

@avtolstoy avtolstoy requested review from sergeuz and technobly Aug 30, 2019

@avtolstoy avtolstoy force-pushed the fix/issues-1.4.0-rc.1-testing branch 3 times, most recently from 73b42a8 to 7ae263f Aug 30, 2019

@avtolstoy avtolstoy force-pushed the fix/issues-1.4.0-rc.1-testing branch from 7ae263f to 7bdf780 Aug 30, 2019

Copy link

left a comment

Looks good to me 👍

@avtolstoy avtolstoy merged commit 2a127f7 into develop Aug 30, 2019

2 of 3 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
continuous-integration/travis-ci/pr The Travis CI build passed
coverage/coveralls First build on fix/issues-1.4.0-rc.1-testing at 42.476%

@avtolstoy avtolstoy deleted the fix/issues-1.4.0-rc.1-testing branch Aug 30, 2019

if (compatQual >= 0 && compatQual <= 7) {
signal->qual = compatQualMap[compatQual];

This comment has been minimized.

Copy link

technobly Aug 30, 2019


Since we already calculate the signal/qual in signalExt, could we fix this with less code and more accuracy by adding signal->rssi = signalExt->rsrp / 100; and signal->qual = signalExt->rsrq / 100; in cellular_hal.cpp? I would like to make sure we are not calculating two different things for the Cellular.RSSI() API and Vitals. Also there is a ch35974 for this.

This comment has been minimized.

Copy link

avtolstoy Aug 30, 2019

Author Member

We can't. This is exactly what is needed to provide the compatibility with what's available on Electron. Going forward we simply need to encourage the usage of, which is the same thing that the vitals are using.

@avtolstoy avtolstoy referenced this pull request Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.