Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[ch34058] update release script to include Electron without DEBUG_BUILD=y and tinker-serial-debugging apps for Gen 3 #1903
Steps to Test
-- [internal] [ch34058] update release script to include Electron without DEBUG_BUILD=y and
Firstly, the build logic looks like it will work as expected.
My only concern is regarding the introduction of "special logic" for certain platforms. My preference would be for us to make a decision about what we generate during the build, and those artifacts should be generated for all applicable platforms.
@zfields The motivation behind this is just to keep the build process as short as possible. We could use more debugging apps for Gen 3, but those same debugging apps are not useful for Core/Photon/P1 as those platforms don't have many (or any) logs available by default. So no reason to build and distribute more than just the one debugging app (--debug) for those.