Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ch34058] update release script to include Electron without DEBUG_BUILD=y and tinker-serial-debugging apps for Gen 3 #1903

Merged
merged 1 commit into from Sep 8, 2019

Conversation

@technobly
Copy link
Member

commented Sep 4, 2019

Problem

  • Some customers would like the Electron released with DEBUG_BUILD=n
  • When debugging Gen 3 devices, it is very convenient to use tinker-serial-debugging if you do not have a Serial USB adapter for use with tinker-serial1-debugging that is already being generated.

Solution

  • Add Electron release binaries without DEBUG_BUILD=y
  • Add Gen 3 tinker-serial-debugging apps (USB output)

Steps to Test

build $ ./make_release.sh --platform=electron --debug --publish=1.4.0-rc.1
build $ ./make_release.sh --platform=boron --debug --publish=1.4.0-rc.1
// repeat last command for other Gen 3 devices if desired

References

ch34058


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • N/A Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

-- [internal] [ch34058] update release script to include Electron without DEBUG_BUILD=y and tinker-serial-debugging apps for Gen 3 #1903

@technobly technobly added the internal label Sep 4, 2019

@technobly technobly added this to the 1.4.0 milestone Sep 4, 2019

@technobly technobly requested a review from zfields Sep 4, 2019

build/release.sh Outdated Show resolved Hide resolved
build/release.sh Show resolved Hide resolved
@zfields

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

Firstly, the build logic looks like it will work as expected.

My only concern is regarding the introduction of "special logic" for certain platforms. My preference would be for us to make a decision about what we generate during the build, and those artifacts should be generated for all applicable platforms.

@technobly

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

My only concern is regarding the introduction of "special logic" for certain platforms. My preference would be for us to make a decision about what we generate during the build, and those artifacts should be generated for all applicable platforms.

@zfields The motivation behind this is just to keep the build process as short as possible. We could use more debugging apps for Gen 3, but those same debugging apps are not useful for Core/Photon/P1 as those platforms don't have many (or any) logs available by default. So no reason to build and distribute more than just the one debugging app (--debug) for those.

@zfields
zfields approved these changes Sep 4, 2019

@zfields zfields added ready to merge and removed needs review labels Sep 4, 2019

@avtolstoy

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

@technobly Do we want to backport this to 1.3.1?

@technobly

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

@avtolstoy it’s not absolutely required but it would be a nice thing to do. Let me know if you’d like me to make a PR for it.

@technobly technobly force-pushed the ch34058/release_script_updates branch from 16bf11a to 10c7388 Sep 7, 2019

@avtolstoy avtolstoy force-pushed the develop branch from 0150e70 to 3dd3d49 Sep 8, 2019

[ch34058] update release script to include...
- electron release binaries without DEBUG_BUILD=y
- Gen 3 tinker-serial-debugging apps (USB output)

@technobly technobly force-pushed the ch34058/release_script_updates branch from 10c7388 to f23bd9a Sep 8, 2019

@technobly technobly changed the title [ch34058] update release script to include... [ch34058] update release script to include Electron without DEBUG_BUILD=y and tinker-serial-debugging apps for Gen 3 Sep 8, 2019

@technobly technobly merged commit a1f0ed6 into develop Sep 8, 2019

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 42.422%
Details

@technobly technobly deleted the ch34058/release_script_updates branch Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.