Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bugfixes #1905

Merged
merged 5 commits into from Sep 5, 2019

Conversation

@sergeuz
Copy link
Member

commented Sep 4, 2019

This PR fixes a number of issues which I encountered while testing Device OS with a local device service instance:

  • Due to a regression introduced in 1.1.0, the system layer always sends its handshake messages, even if the session was resumed. This causes increased data usage.

  • rand() isn't properly seeded in multiple threads, including the system thread. On Gen 3 specifically this breaks allocation of ephemeral port numbers in LwIP.

  • Control requests that reset the device (e.g. particle usb dfu) can cause unnecessary reconnection to the cloud.

  • User module isn't initialized in monolithic builds.

CHANGELOG

BUGFIXES

  • Fixes a regression introduced in 1.1.0 where the system layer was always sending its handshake messages even if the session was resumed causing increased data usage #1905
  • Properly seeds rand() in multiple threads including system thread. Fixes ephemeral port allocation in LwIP on Gen 3 platforms #1905
  • Control requests that reset the device (e.g. particle usb dfu) no longer cause unnecessary reconnection to the cloud #1905
  • Initialize user module in monolithic builds #1905

@sergeuz sergeuz requested a review from avtolstoy Sep 4, 2019

@avtolstoy
Copy link
Member

left a comment

LGTM

@avtolstoy

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

I'm going to backport these to 1.3.1 as well.

@avtolstoy avtolstoy merged commit e58b5eb into develop Sep 5, 2019

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 42.422%
Details

@avtolstoy avtolstoy deleted the fix/misc branch Sep 5, 2019

@avtolstoy avtolstoy referenced this pull request Sep 5, 2019

@technobly technobly added this to the 1.4.0 milestone Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.