Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mix logging and serial console output #1909

Merged
merged 2 commits into from Sep 9, 2019

Conversation

@sergeuz
Copy link
Member

commented Sep 9, 2019

Problem

This PR cherry-picks cae58bc from #1748 to make sure logging over Serial does not interfere with the serial console in listening mode.

Steps to Test

Flash tinker-serial-debugging and verify that the device can be flashed over the serial interface without errors.

@sergeuz sergeuz added this to the 1.4.0 milestone Sep 9, 2019

@sergeuz sergeuz requested a review from avtolstoy Sep 9, 2019

@avtolstoy
Copy link
Member

left a comment

LGTM

@sergeuz sergeuz merged commit 60c5e50 into develop Sep 9, 2019

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 42.422%
Details

@sergeuz sergeuz deleted the fix/ch38148/serial_logging branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.