Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor test fixes for 1.4.0 #1912

Merged
merged 3 commits into from Sep 10, 2019

Conversation

@avtolstoy
Copy link
Member

commented Sep 10, 2019

Description

  1. Fixes a bug in IPAddress::operator bool() for IPv6 addresses
  2. Changes a default pin from D0 to A0 in GPIO tests. D0 is usually an I2C pin as well, so the test might not work depending on how things are wired (e.g. on SoM EVB)
  3. Minor fixes in NETWORK_01_LargePacketsDontCauseIssues_ResolveMtu

Steps to Test

  • wiring/no_fixture GPIO* on BSoM
  • wiring/no_fixture_long_running on a Xenon

Example App

N/A

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy added this to the 1.4.0 milestone Sep 10, 2019

@avtolstoy avtolstoy requested a review from sergeuz Sep 10, 2019

@avtolstoy avtolstoy merged commit e696a41 into develop Sep 10, 2019

0 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details

@avtolstoy avtolstoy deleted the fix/tests-minor-1.4.0 branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.