[wiring] Fix SPI macros polluting global namespace #2089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SPI
,SPI1
andSPI2
are defines in wiring. Such generic macro names pollute the global namespace and easily cause issue e.g. #2077Solution
Add a proxy class that would delegate the calls to actual wiring SPI objects, while still maintaining singleton-like static initialization of them.
This PR also updates SPI API tests, as they have not been complete.
Steps to Test
wiring/api
wiring/no_fixture
wiring/no_fixture_spi
Example App
N/A
References
Completeness