[wiring] spi: an attempt to bring back compatibility with SPIClass #2095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A number of libraries rely on the internals of our wiring SPI implementation (
SPIClass
). After introducing a proxy class in #2089, we inadvertently broke them.Solution
As a workaround we can introduce implicit conversion operator to the proxy class to convert to
SPIClass&
, as well asoperator&
overload to be able to convert a proxy instance toSPIClass*
. This is not ideal, but pretty much the simplest thing we can do.Steps to Test
wiring/api
Example App
N/A
References
Completeness