Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gen3] ble: fix unintialized scan_phys in default scan parameters #2338

Merged
merged 1 commit into from Jul 14, 2021

Conversation

avtolstoy
Copy link
Member

Problem

scan_phys in default BLE scan parameters are not initialized.

Solution

Initialize correctly.

Steps to Test

Run wiring/ble* tests.

Example App

N/A

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy added this to the 3.1.1 milestone Jul 14, 2021
@tstellanova
Copy link
Contributor

Verified with ble scanner app:

  • Flash tracker to dvos 3.1.0
  • Flash with nortrack built against 3.0.0
  • Verify ble beacons are not scanned correctly
  • Build and flash dvos with this PR changelist
  • reflash nortrack built against 3.0.0
  • Verify ble beacons are scanned correctly

@avtolstoy
Copy link
Member Author

Thanks folks. I'm merging this and will add a couple of PRs on top:

  1. -Wextra fixes
  2. Changes to BLE tests to be non-interactive and use device-os-test-runner

@avtolstoy avtolstoy merged commit 622450d into develop Jul 14, 2021
@avtolstoy avtolstoy deleted the fix/ble-scan-params branch July 14, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants