[test] fix listening network tests #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
approved these changes
Mar 31, 2022
technobly
approved these changes
Mar 31, 2022
technobly
force-pushed
the
tests/fix-listening-network-tests
branch
from
cde82bc
to
dc63811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
NETWORK_00 and NETWORK_01 tests which are in the beginning of the test suite depend on the previous tests to establish a cloud connection. If a cloud connection was not established successfully in the previous tests, these tests immediately fail.
Solution
Reduce dependency by adding API to connect to Network and add relevant scope guards to ensure listening mode is disabled in LISTENING_XX tests.
Steps to Test
Run on-device tests
References
N/A
Completeness