Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes RSA private key generation #779

Merged
merged 3 commits into from Dec 22, 2015

Conversation

@avtolstoy
Copy link
Member

commented Dec 22, 2015

Certain P/Q/DP/DQ/QP values caused RSAPrivateKeyWriter to generate incorrect private key in DER format.

avtolstoy added 3 commits Dec 22, 2015
Fixes RSA private key generation
Certain P/Q/DP/DQ/QP values caused RSAPrivateKeyWriter to generate incorrect private key in DER format.
Test app that generates RSA keypairs and dumps through Serial.
The keys validity can be verified by verify_keys.py script.
m-mcgowan added a commit that referenced this pull request Dec 22, 2015
Merge pull request #779 from avtolstoy/rsa_der_generation
Fixes RSA private key generation

@m-mcgowan m-mcgowan merged commit b522e40 into particle-iot:develop Dec 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented Dec 22, 2015

Nice work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.