Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added write-verify-retry-fail logic to DFU writes #870

Merged
merged 2 commits into from Mar 10, 2016

Conversation

@technobly
Copy link
Member

commented Feb 9, 2016

Tested by making several special versions that inject failures after 15 seconds of runtime, one modified the flash Address that was used in the verify routine. Typical time to write v0.4.8-rc.6 system part 1 and 2 for electron via particle update is about 16.2 seconds before and after new verification process (i.e., it doesn't appear to lengthen the process, most likely due to overall lengthy delays in the DFU process padding the overhead - more on this later...).

added write-verify-retry-fail logic to DFU writes
tested by making several special versions that inject failures after 15 seconds of runtime, one modified the flash Address that was used in the verify routine.  Typical time to write v0.4.8-rc.6 system part 1 and 2 for electron via `particle update` is about 16.2 seconds before and after new verification process (i.e., it doesn't appear to lengthen the process, most likely due to overall lengthy delays in the DFU process padding the overhead - more on this later...).

@technobly technobly self-assigned this Feb 9, 2016

@technobly technobly added this to the 0.5.x milestone Feb 9, 2016

m-mcgowan added a commit that referenced this pull request Mar 10, 2016
Merge pull request #870 from spark/feature/dfu-write-verify-retry
added write-verify-retry-fail logic to DFU writes

@m-mcgowan m-mcgowan merged commit efc9396 into develop Mar 10, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@m-mcgowan m-mcgowan deleted the feature/dfu-write-verify-retry branch Sep 27, 2016

@technobly technobly removed their assignment Dec 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.