Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular Band Select API #891

Merged
merged 3 commits into from Mar 10, 2016

Conversation

@technobly
Copy link
Member

commented Mar 3, 2016

Docs and examples to be added here

  • Review code
  • Test on device
  • Add documentation
  • Add to changelog
technobly added 3 commits Feb 23, 2016
adds integration tests for Cellular Band Select API
required for this to compile and run `git cherry-pick 3076956`
also will merge with cellular.cpp from feature/electron/localip and feature/electron/datausage
refactoring cellular_hal.h to be platform agnostic
added new cellular_internal.h to scr/electron for platform specific function prototypes
added Wiring_Cellular conditional compile checks for Cellular
added PLATFORM_ID conditional compile checks for platform specific dynalib headers

@technobly technobly self-assigned this Mar 3, 2016

@technobly technobly added this to the 0.5.x milestone Mar 3, 2016

@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2016

very nice :-)

m-mcgowan added a commit that referenced this pull request Mar 10, 2016

@m-mcgowan m-mcgowan merged commit 9baa3ff into feature/electron/datausage Mar 10, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@m-mcgowan m-mcgowan referenced this pull request Mar 10, 2016
17 of 17 tasks complete

@technobly technobly removed the in progress label Apr 3, 2016

@technobly technobly deleted the feature/electron/bandselect branch Oct 27, 2016

@technobly technobly removed their assignment Dec 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.