Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYSTEM_FLAG_WIFITEST_OVER_SERIAL1 #945

Merged
merged 1 commit into from Apr 14, 2016

Conversation

@m-mcgowan
Copy link
Contributor

commented Apr 7, 2016

adds SYSTEM_FLAG_WIFITEST_OVER_SERIAL1 which is disabled by default. Tinker enables this so that the WiFi tester is available during manufacturing.


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)
adds `SYSTEM_FLAG_WIFITEST_OVER_SERIAL1` which is disabled by default…
…. Tinker enables this so that the WiFi tester is available during manufacturing.

@monkbroc monkbroc added the in progress label Apr 7, 2016

@sergeuz sergeuz referenced this pull request Apr 7, 2016
4 of 4 tasks complete

@m-mcgowan m-mcgowan added this to the 0.5.x milestone Apr 12, 2016

@m-mcgowan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2016

How to enable (enabled by default in Tinker now):

STARTUP(System.enable(SYSTEM_FLAG_WIFITESTER_OVER_SERIAL1));

How to disable is enabled (disabled by default if no code included):

STARTUP(System.disable(SYSTEM_FLAG_WIFITESTER_OVER_SERIAL1));

Tests to perform:

  • disable the flag SYSTEM_FLAG_WIFITEST_OVER_SERIAL1
  • verify TX is an input (can pull high and low with 1k ohm resistor)
  • enter setup mode (Listening Mode)
  • verify TX is still an input (can pull high and low with 1k ohm resistor)
  • enable the flag SYSTEM_FLAG_WIFITEST_OVER_SERIAL1
  • verify TX is an input (can pull high and low with 1k ohm resistor)
  • enter setup mode (Listening Mode)
  • verify TX is no longer an input, it should go to 3.3V
@technobly

This comment has been minimized.

Copy link
Member

commented Apr 14, 2016

@m-mcgowan I edited the above test procedure and executed it.

@technobly technobly assigned technobly and unassigned technobly Apr 14, 2016

@m-mcgowan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2016

Does this need adding to the docs? This feels like an internal feature.

@technobly

This comment has been minimized.

Copy link
Member

commented Apr 14, 2016

Product creators will possibly want to take advantage of this right?

@technobly technobly merged commit b9c71cd into develop Apr 14, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@monkbroc monkbroc removed the in progress label Apr 14, 2016

@markterrill

This comment has been minimized.

Copy link

commented Jun 17, 2016

Hi, a while back I was emailed the PDF with how to run wifi testing for lab certification. Involved a complicated JTAG reprogramming then using UART to send custom commands to the board to try specific bands at n power.
Is this now in tinker? because that is massive! would love the most basic docu so I can then use tinker instead of the face north, jtag program, etc etc via serial.
it'd be perfection if we could access those tests via standard code methods, ie test wifi b at power n, and run standard serial (usb) writes for debugging notices. that way it'd be really easy to send to a test lab, instructions simply would be, 'it'll do b for 2 minutes at US limits/chans, 2 minutes at UK, 2 mins at japan, then g for ..'
anyways, starting with not having to jtag reprogram is a big step.

@technobly technobly deleted the feature/wifitester_system_flag branch Oct 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.