Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softap claim code fix #956

Merged
merged 1 commit into from Apr 14, 2016

Conversation

@m-mcgowan
Copy link
Contributor

commented Apr 13, 2016

The problem and steps to reproduce it are described in issue #937.

fixes #937. The memory passed from the parse_json() call is only valid during that call, yet the SetValueCommand was caching these for use later. The fix is to copy the data rather than store the pointer.


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • N/A - API tests compiled
  • Run unit/integration/application tests on device
  • N/A - Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)
fixes #937. The memory passed from the parse_json() call is only vali…
…d during that call, yet the SetValueCommand was caching these for use later. The fix is to copy the data rather than store the pointer.

@m-mcgowan m-mcgowan added this to the 0.5.x milestone Apr 13, 2016

@m-mcgowan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2016

I tested using the node app linked in the issue. I could reproduce the problem, seeing corruption of the claim code. After the fix claim codes work as expected.

@technobly technobly assigned technobly and unassigned technobly Apr 14, 2016

@technobly technobly merged commit 17d57da into develop Apr 14, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@monkbroc monkbroc removed the in progress label Apr 14, 2016

@m-mcgowan m-mcgowan deleted the feature/issue937 branch Sep 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.