Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert EEPROM capacity to 2048 instead of 2047 Photon / 128 Core #983

Merged
merged 1 commit into from Apr 28, 2016

Conversation

@monkbroc
Copy link
Member

commented Apr 26, 2016

The EEPROM rewrite in 0.5.0 inadvertently reduced the EEPROM capacity from 2048 to 2047.

This restores the capacity and adds an explicit on-device test for it.


Doneness:

  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)

@m-mcgowan m-mcgowan added this to the 0.5.1 milestone Apr 27, 2016

@technobly technobly added the bug label Apr 28, 2016

@technobly technobly self-assigned this Apr 28, 2016

@technobly technobly merged commit bc6e2b4 into develop Apr 28, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly removed their assignment Apr 28, 2016

@technobly technobly deleted the feature/eeprom-capacity-revert branch Oct 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.