Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire Hazard, Wrong bitmask is provided for 4208 #987

Merged
merged 1 commit into from Apr 28, 2016

Conversation

@developingchris
Copy link
Contributor

commented Apr 28, 2016

In the Power Management, there is a function for setting the cut off voltage which takes an integer and converts it to the appropriate bit mask.

When sending in 4.208 volts (the upper bound on the LiPo battery provided with spark kits) it sets the voltage to 4.4 volts. This has caused units on our test bench to fail, and could cause fires if using any other standard LiPo battery that doesn't have a limit circuit installed in the battery.

I am not sure how to complete all of the required steps to get this through your processes, but see this bug as a danger, and would appreciate any help in getting it implemented. Or if someone else can do the unit testing required to get it passed I would not mind them taking over the issue.


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)
    When passing in 4208, 4400 is actually set to the register.
    4.2 is the uppper bound on the operating parameters for the battery that
    is provided with the electron.
    It would be nice if this function exposed a wider range of voltages,
    however this change to perform the function as advertised needs to be
    implmented more quickly as it is a fire hazard.
Wrong bitmask is provided for 4208
When passing in 4208, 4400 is actually set to the register.
4.2 is the uppper bound on the operating parameters for the battery that
is provided with the electron.
It would be nice if this function exposed a wider range of voltages,
however this change to perform the function as advertised needs to be
implmented more quickly as it is a fire hazard.
@technobly

This comment has been minimized.

Copy link
Member

commented Apr 28, 2016

@developingchris thanks for the catch! We originally set the default limit to 4.112V for battery safety when exposing the battery to extended temperatures. Not sure how that 4.208V bit mask got to be wrong, but thanks for the catch!

@developingchris

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2016

We really like that this could be variable, as we have some HV batteries and other sources we want to try in our systems, that the electron will be a part of. So I would love to expand this function to accept more values between 3504 and 4300 but 4400 is outside of any LiPo we can source.

@developingchris

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2016

@technobly what is the process for getting this change up to the point where it's part of the binary I'm putting on my electron?

@technobly

This comment has been minimized.

Copy link
Member

commented Apr 28, 2016

@developingchris this should be available soon. Keep an eye on the milestone tag for this PR.

@technobly technobly added the bug label Apr 28, 2016

@technobly technobly added this to the 0.5.1 milestone Apr 28, 2016

@technobly technobly merged commit a290318 into particle-iot:develop Apr 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.