Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server key address output incorrect for Electron using TCP #279

Closed
towynlin opened this issue Sep 17, 2016 · 2 comments

Comments

@towynlin
Copy link
Member

commented Sep 17, 2016

Given I have an Electron with valid keys for the UDP and TCP servers
When I run particle keys protocol tcp
And I run particle keys address
Then I expect the output to be tcp://device.spark.io:5683
But instead I currently see tcp://$id.udp.particle.io:5683

It seems as though the CLI implementation of particle keys address is correctly checking the protocol and correctly changing the port, but incorrectly handling the host name, allowing the CLI default even to be overridden incorrectly.

@m-mcgowan m-mcgowan added the bug label Jan 25, 2017

@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented Jan 27, 2017

I couldn't reproduce this with CLI 1.19.2. It printed out the correct address.

@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2017

The keys and protocol handling has been revamped, so this issue should be fixed, although I couldn't reproduce it.

@m-mcgowan m-mcgowan closed this Feb 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.