Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys doctor (device id) is case sensitive? #321

Closed
dmiddlecamp opened this issue Jan 12, 2017 · 3 comments

Comments

@dmiddlecamp
Copy link
Member

commented Jan 12, 2017

Opening a ticket because I got a report that the keys doctor treats device-ids as case sensitive, maybe we should lowercase them before hitting the api / generating keys?

@ScruffR

This comment has been minimized.

Copy link

commented Jan 14, 2017

Yup, that was my report - but please don't just restrict that fix to keys doctor.

Any command that takes a device ID, an access token, a webhook ID or any other hex number should be case-insensitive.

IMHO #208 should not have been closed, since the workaround there wasn't really addressing the issue but only providing a short-term workaround - and if this issue would now be limited to keys doctor only, it can be expected that a similar issue will pop up sooner or later again.

@ScruffR

This comment has been minimized.

Copy link

commented Jan 23, 2017

@m-mcgowan m-mcgowan added enhancement bug and removed enhancement labels Jan 23, 2017

@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented Jan 26, 2017

If we expect deviceIDs to be case insensitive, shouldn't this go in the API rather than pushing the burden to all clients?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.