Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: added delete all command #205

Merged
merged 1 commit into from Jan 25, 2017

Conversation

@kennethlimcp
Copy link
Contributor

commented Feb 8, 2016

  • allows mass deletion of all webhook
  • logic might need to be improved. current might not be async?
  • test to be implemented for completeness
  • docs PR will be required as well

Signed-off-by: Kenneth Lim kennethlimcp@gmail.com

webhook: added delete all command
- allows mass deletion of all webhook
- logic might need to be improved. current might not be async?
- test to be implemented for completeness
- docs PR will be required as well

Signed-off-by: Kenneth Lim <kennethlimcp@gmail.com>
@m-mcgowan
Copy link
Contributor

left a comment

Looks fine to me. I wonder if we should list all the webhooks first that will be deleted, and then ask for confirmation?

@kennethlimcp

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2016

What information about the webhook will be useful during listing?

@m-mcgowan m-mcgowan changed the base branch from master to develop Jan 25, 2017

@m-mcgowan m-mcgowan merged commit 0c9205e into particle-iot:develop Jan 25, 2017

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.03%) to 19.28%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented Jan 25, 2017

@kennethlimcp - would you mind adding (and linking here) a PR to the docs repo for this? Thanks!

@kennethlimcp

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2017

Will work on the docs and get back to this ;)

@kennethlimcp kennethlimcp deleted the kennethlimcp:webhook/delete-all branch Jan 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.