Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sc 124023/delete refactor #709

Merged

Conversation

hugomontero
Copy link
Contributor

@hugomontero hugomontero commented Jan 5, 2024

Description

This PR will change delete command in order to use LogicFunction Class

How to Test

  1. Pull down the branch: git pull && git checkout feature/sc-124023/delete-refactor
  2. Install dependencies: npm i
  3. Run tests: npm run test:ci && npm run test:e2e -- --grep "Logic Function Commands"
  4. Attempt to delete a logic function:
    • Delete by name: `npm start -- lf delete --name ""
    • Delete by id: `npm start -- lf delete --id ""
    • Delete wrong name/id: npm start -- lf delete --name "<wrong name>"
    • Delete without name/id: npm start -- lf delete

outcome

  • Tests should pass
  • In every attempt your Logic function will be deleted
  • If the logic function doesn't exist it will show an error Logic function not found
  • When you don't pass any param to delete it will prompt to you a list of logic functions to delete

Related Issues / Discussions

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@hugomontero hugomontero force-pushed the feature/sc-124023/delete-refactor branch from b48aaaa to 4e5f7ba Compare January 5, 2024 13:55
@hugomontero hugomontero marked this pull request as ready for review January 5, 2024 14:25
@hugomontero hugomontero force-pushed the feature/sc-124023/delete-refactor branch from 4e5f7ba to 9cb38ba Compare January 5, 2024 14:27
@keeramis
Copy link
Contributor

keeramis commented Jan 5, 2024

@hugomontero do you want to fix the empty braces? I am guessing you should put the ID of the newly deployed logic function there. Currently it shows empty

image

Copy link
Contributor

@keeramis keeramis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #709 (comment)

@hugomontero
Copy link
Contributor Author

@hugomontero do you want to fix the empty braces? I am guessing you should put the ID of the newly deployed logic function there. Currently it shows empty

image

I'll fix this one in the PR #710, since that one updates the way we show the texts (adding the spinners) 😄

@hugomontero hugomontero merged commit 0bb1bc2 into feature/logic-function Jan 8, 2024
6 checks passed
@hugomontero hugomontero deleted the feature/sc-124023/delete-refactor branch January 8, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants