Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/sc-126610/make-particle-cli-uses-serial-to-configure #720

Conversation

hugomontero
Copy link
Contributor

@hugomontero hugomontero commented Mar 26, 2024

Description

This PR will change the way gen3 and above configure wifi:
Since ControlRequest doesn't allow to pre-load wifi credentials, we have to change the wifi configuration to use serial

How to Test

  1. Pull down the branch: git pull && git checkout feature/sc-126610/make-particle-cli-uses-serial-to-configure
  2. Install dependencies: npm i
  3. Attempt to manually configure a p2 / argon device:
    • npm start -- usb listen
    • npm start -- serial wifi
  4. Attempt to configure a p2 / argon device with a file (make sure that network can't be reached out):
    • npm start -- usb listen
    • npm start -- serial wifi --file /path/to/my/file.json
    • Go to wifi-tool and verify your configured networks

Related Issues / Discussions

  • Tests should pass
  • Manually configuration should be ok
  • file configuration should pass
  • Going to wifi-tool you will be able to see your stored wifi network

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@hugomontero hugomontero changed the title use serial to configure gen3+ wifi devices feature/sc-126610/make-particle-cli-uses-serial-to-configure Mar 26, 2024
@hugomontero hugomontero marked this pull request as ready for review March 26, 2024 15:18
Copy link
Member

@monkbroc monkbroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested to work with a Wi-Fi network that exists and one that doesn't exist on an Argon and Photon 2. I tested manual input and JSON file input.

@hugomontero hugomontero merged commit 866198b into master Mar 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants