New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Newtonsoft.Json 12.0.1 #322

Closed
gbiellem opened this Issue Nov 28, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@gbiellem
Copy link
Contributor

gbiellem commented Nov 28, 2018

Adds support for Newtonsoft.Json version 12.0.1


Originally submitted by @gbiellem
Newtonsoft.Json 12.0.1 is released but the dependency constraints on this are holding us back on 11

@SzymonPobiega

This comment has been minimized.

Copy link
Member

SzymonPobiega commented Nov 28, 2018

Hi @gbiellem

Thanks for the ping. We'll add it to our board.

@SimonCropp

This comment has been minimized.

Copy link
Contributor

SimonCropp commented Nov 28, 2018

given this will be binding redirect issues for most users, can we get this fast tracked

@SimonCropp

This comment has been minimized.

Copy link
Contributor

SimonCropp commented Nov 28, 2018

actually it will break the build :(

Error	NU1608	Detected package version outside of dependency constraint: 
NServiceBus.Persistence.Sql 4.3.0 requires Newtonsoft.Json (>= 11.0.1 && < 12.0.0) 
but version Newtonsoft.Json 12.0.1 was resolved.	
@SimonCropp

This comment has been minimized.

Copy link
Contributor

SimonCropp commented Dec 4, 2018

any progress?

@SzymonPobiega

This comment has been minimized.

Copy link
Member

SzymonPobiega commented Dec 4, 2018

@SimonCropp we're starting work on this.

@indualagarsamy indualagarsamy added this to the 4.4.0 milestone Dec 11, 2018

@indualagarsamy indualagarsamy changed the title Support Newtonsoft.Json 12.x Support Newtonsoft.Json 12.0.1 Dec 11, 2018

@indualagarsamy

This comment has been minimized.

Copy link
Member

indualagarsamy commented Dec 11, 2018

Closing issue via PR #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment