Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for Internal Part Number #501

Closed
fulcrum3d opened this issue Nov 25, 2015 · 11 comments
Closed

Searching for Internal Part Number #501

fulcrum3d opened this issue Nov 25, 2015 · 11 comments
Milestone

Comments

@fulcrum3d
Copy link

Hi,

after downloading the new update, i am not able to search for any other information besides the description. Why did you do that? That is a huge problem for us, as we track down our parts with the the internal part number.

Would there a be way to make it possible to still search for the internal part number? Besides downgrading the software

thanks

@Drachenkaetzchen
Copy link
Member

I will have a look why this happens. If it's not a big issue, the fix will be included in the next release, due in a few days.

@Drachenkaetzchen Drachenkaetzchen added this to the 0.76 milestone Nov 25, 2015
@fulcrum3d
Copy link
Author

Thank you.

Additionally, it would be useful to see in which projects a certain part is. (Like before)
And we discovered that it is not possible to add new parts to previously created projects.

Cheers

@Drachenkaetzchen
Copy link
Member

Could you please open separate issues for each individual bug? Thank you

@Drachenkaetzchen
Copy link
Member

I can offer a quick fix where the internal part number can be searched by the part filter panel:

image

I also plan on re-introducing the behaviour of 0.1.9, however, it's not possible to do a very quick fix.

@Drachenkaetzchen
Copy link
Member

Internal note: The 0.1.9 version did search the fields "comment", "name", "description" and "internalPartNumber". To make this work again, the AdvancedSearchFilter must be modified to allow OR queries. Right now, the AdvancedSearchFilter only allows AND queries.

@Drachenkaetzchen
Copy link
Member

@fulcrum3d if you wish to use the quick fix where you can use the part filter panel for searching the internal part number, you can replace the file src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartFilterPanel.js with the contents of 4952121 and then re-run setup (or re-generate the environment as described in the wiki)

@fulcrum3d
Copy link
Author

Thank you very much, felicitus!! You really helped us. We appreciate your fast answers! :)

@Drachenkaetzchen
Copy link
Member

The internal part number has been added to the search filter, however, I really would like that the search field on the top right beheaves exactly like in previous versions. As this is quite a bit of effort, the final solution will be implemented in a later version.

@Drachenkaetzchen
Copy link
Member

I have added support for searching within name, description, internal part number and comments. Please try it out on the demo system in about one hour.

@Drachenkaetzchen Drachenkaetzchen modified the milestones: 1.0.1, 1.1 Jul 30, 2016
@Drachenkaetzchen
Copy link
Member

I believe the issue is fixed now, can you confirm?

@DoctorOctagonapus
Copy link

Not OP but it's working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants