Skip to content

Apply system appearance via UIKit/AppKit#1200

Merged
keeshux merged 3 commits into
masterfrom
bugfix/system-appearance
Feb 18, 2025
Merged

Apply system appearance via UIKit/AppKit#1200
keeshux merged 3 commits into
masterfrom
bugfix/system-appearance

Conversation

@keeshux

@keeshux keeshux commented Feb 18, 2025

Copy link
Copy Markdown
Member

SwiftUI implementation is fragile, system appearance with preferredColorScheme(nil) is buggy.

Instead, rely on:

  • iOS: UIKit → UIWindow.overrideUserInterfaceStyle
  • macOS: AppKit → NSApp.appearance

Amends #1077

Fixes #1199

@keeshux keeshux self-assigned this Feb 18, 2025
@keeshux keeshux added bug Something isn't working iOS Related to the iOS app macOS Related to the macOS app labels Feb 18, 2025
@keeshux keeshux merged commit 42a1861 into master Feb 18, 2025
@keeshux keeshux deleted the bugfix/system-appearance branch February 18, 2025 00:16
@keeshux keeshux mentioned this pull request Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working iOS Related to the iOS app macOS Related to the macOS app

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

"System" appearance is wrong

1 participant