Permalink
Commits on Apr 9, 2012
  1. passing sessionStrategy into authenticationListenerFactories individu…

    Stefan Paschke committed Apr 9, 2012
    …ally
  2. reuse the instance level loader n src/Symfony/Bundle/SecurityBundle/D…

    Stefan Paschke committed Apr 9, 2012
    …ependencyInjection/SecurityExtension::sessionRegistryLoad
  3. reacting to comments on PR 786

    Stefan Paschke committed Apr 9, 2012
Commits on Apr 8, 2012
  1. Merge branch 'master' of git://github.com/symfony/symfony

    Stefan Paschke committed Apr 8, 2012
  2. removed @return void comments

    Stefan Paschke committed Apr 8, 2012
  3. [TwigBundle] simplified code

    fabpot committed Apr 8, 2012
  4. merged branch marcw/feat-twig-lint (PR #3804)

    fabpot committed Apr 8, 2012
    Commits
    -------
    
    8726ade Adds more features to twig:lint command
    1d7e9d9 Adds a linter command for templates
    
    Discussion
    ----------
    
    Adds a linter command for templates
    
    Let's this PR be stoffed. ;)
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-04-06T15:48:18Z
    
    Checking a single file is very limited. Checking a whole directory would be more useful, wouldn't it?
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2012-04-06T17:56:57Z
    
    I think you should provide a way to validate all templates for a given bundle, something like:
    
        php app/console twig:lint @MySuperBundle
    
    ---------------------------------------------------------------------------
    
    by henrikbjorn at 2012-04-06T18:03:45Z
    
    Wouldnt it be better to throw some kind of exception if the lint is erroneous?
    
    ---------------------------------------------------------------------------
    
    by marcw at 2012-04-07T11:22:34Z
    
    @Tobion @willdurand  You can do that by combining unix tools.
    @henrikbjorn Why ?
    
    ---------------------------------------------------------------------------
    
    by marcw at 2012-04-07T11:27:11Z
    
    Updated.
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-04-07T13:15:53Z
    
    @marcw it would be indeed nice to have support for a bundle/directory out of the box as some of the Symfony2 users might not be running unix or know the right commands to make this work.
    
    I could help you with a PR in your repo if you want.
    
    ---------------------------------------------------------------------------
    
    by henrikbjorn at 2012-04-07T18:55:34Z
    
    @marcw as the console component will catch them and convert them into the right error code, also will display what went wrong instead of just dieing.
    
    ---------------------------------------------------------------------------
    
    by marcw at 2012-04-08T09:15:37Z
    
    Updated with all comments and requested features.
  5. Adds more features to twig:lint command

    marc.weistroff committed Apr 8, 2012
  6. merged branch ruimarinho/exception_css_tweaks (PR #3827)

    fabpot committed Apr 8, 2012
    Commits
    -------
    
    fad114b Tweaked the exceptions layout CSS in order to display the error message even when wrapped around <pre> tags
    
    Discussion
    ----------
    
    Tweaked the exceptions layout CSS in order to display the error message even when wrapped around <pre> tags
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: ![Build status](https://secure.travis-ci.org/ruimarinho/symfony.png?branch=exception_css_tweaks)
    Fixes the following tickets: -
    Todo: -
    
    Ever been in a situation when you're debugging code wrapped around `<pre>` tags and that code throws an exception? If you're familiar with this screenshot, you have :-) ![Image](http://i.imgur.com/dwxdD.png)
    
    This PR is just a little tweak to the exceptions layout CSS in order to allow your to view the exception message. It also fixes a word break when messages are too long. ![Image 2](http://i.imgur.com/whxZv.png).
    
    The build is currently failing due to an unmerged patch from the 2.0 branch.
  7. merged 2.0

    fabpot committed Apr 8, 2012
  8. merged branch eriksencosta/test-fixes (PR #3830)

    fabpot committed Apr 8, 2012
    Commits
    -------
    
    fdee352 [TwigBridge] updated suggested packages
    dad1750 [TwigBridge] updated TestCase as an abstract class
    140ac20 [TwigBridge] fixed bootstrap
    
    Discussion
    ----------
    
    [TwigBridge] updated Composer suggested packages and test fixes
    
    ---------------------------------------------------------------------------
    
    by eriksencosta at 2012-04-08T06:13:53Z
    
    Rebased.
  9. merged branch jakzal/FilesystemBugFix (PR #3828)

    fabpot committed Apr 8, 2012
    Commits
    -------
    
    22e2ad8 [Filesystem] Fixed relative path calculation for end path which is a subdirectory of the start path.
    bc93787 [Filesystem] Fixed relative path calculation for paths with various combinations of trailing directory separators.
    
    Discussion
    ----------
    
    [Filesystem] Fixed relative path calculation
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
Commits on Apr 7, 2012
  1. [Filesystem] Fixed relative path calculation for end path which is a …

    jakzal committed Apr 7, 2012
    …subdirectory of the start path.
  2. [Filesystem] Fixed relative path calculation for paths with various c…

    jakzal committed Apr 7, 2012
    …ombinations of trailing directory separators.
  3. merged branch jakzal/SetCookieWithMultipleCookiesBugFix (PR #3823)

    fabpot committed Apr 7, 2012
    Commits
    -------
    
    7f92833 [BrowserKit] Fixed cs.
    df3da28 [BrowserKit] Using assertNull instead of assertEquals.
    87890d3 [BrowserKit] Fixed CookieJar issue being unable to parse multiple cookies from Set-Cookie.
    
    Discussion
    ----------
    
    [BrowserKit] Fixed CookieJar being unable to parse multiple cookies
    
    Fix proposition for #3109
    
    My fix splits value of *Set-Cookie* header by comma. Than it checks each extracted part if it starts with a cookie-name (token). If check is positive cookie is added to the list. Otherwise it's appended to the previous value. First element is always added to the list.
    
    [rfc6265](http://tools.ietf.org/html/rfc6265) defines cookie-name with token:
    
        cookie-name = token
        token = <token, defined in [RFC2616], Section 2.2>
    
    token is defined in [rfc2616](http://tools.ietf.org/html/rfc2616#section-2.2) as follows:
    
        token = 1*<any CHAR except CTLs or separators>
        CHAR = <any US-ASCII character (octets 0 - 127)>
        separators = "(" | ")" | "<" | ">" | "@"
                      | "," | ";" | ":" | "\" | <">
                      | "/" | "[" | "]" | "?" | "="
                      | "{" | "}" | SP | HT
    
    That means cookie-name can be built out of following set of characters: *! # $ % & ' * + - . ^ _ ` | ~ 0-9 A-Z a-z*
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
  4. [BrowserKit] Fixed cs.

    jakzal committed Apr 7, 2012
  5. merged branch bschussek/issue3661 (PR #3821)

    fabpot committed Apr 7, 2012
    Commits
    -------
    
    e0ce6b4 [Form] Fixed required value guessed by ValidatorTypeGuesser
    
    Discussion
    ----------
    
    [Form] Fixed required value guessed by ValidatorTypeGuesser
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no*
    Symfony2 tests pass: yes
    Fixes the following tickets: #3661
    Todo: -
    
    ![Travis Build Status](https://secure.travis-ci.org/bschussek/symfony.png?branch=issue3661)
    
    The documentation states that a field is set to required if constrained with NotBlank or NotNull and to not required otherwise. Due to a bug this was not the case and fields were always required. This is now fixed.
    
    The consequence is that some fields that were required before by default are not required anymore. The only difference is that the HTML5 "required" attribute disappears, because server-side validation did not occur before anyway.
  6. [BrowserKit] Fixed CookieJar issue being unable to parse multiple coo…

    jakzal committed Apr 7, 2012
    …kies from Set-Cookie.
  7. Tweaked the exceptions layout CSS in order to display the error messa…

    Rui Marinho committed Apr 5, 2012
    …ge even when wrapped around <pre> tags
  8. Adds a linter command for templates

    marc.weistroff committed Apr 6, 2012
  9. merged branch jakzal/FilesystemTests (PR #3811)

    fabpot committed Apr 7, 2012
    Commits
    -------
    
    100e97e [Filesystem] Fixed warnings in makePathRelative().
    f5f5c21 [Filesystem] Fixed typos in the docblocks.
    d4243a2 [Filesystem] Fixed a bug in remove being unable to remove symlinks to unexisting file or directory.
    11a676d [Filesystem] Added unit tests for mirror method.
    8c94069 [Filesystem] Added unit tests for isAbsolutePath method.
    2ee4b88 [Filesystem] Added unit tests for makePathRelative method.
    21860cb [Filesystem] Added unit tests for symlink method.
    a041feb [Filesystem] Added unit tests for rename method.
    8071859 [Filesystem] Added unit tests for chmod method.
    bba0080 [Filesystem] Added unit tests for remove method.
    8e861b7 [Filesystem] Introduced workspace directory to limit complexity of tests.
    a91e200 [Filesystem] Added unit tests for touch method.
    7e297db [Filesystem] Added unit tests for mkdir method.
    6ac5486 [Filesystem] Added unit tests for copy method.
    1c833e7 [Filesystem] Added missing docblock comment.
    
    Discussion
    ----------
    
    [Filesystem] Fixed a bug in remove() being unable to unlink broken symlinks
    
    While working on test coverage for Filesystem class I discovered a bug in remove() method.
    
    Before removing a file a check is made if it exists:
    
        if (!file_exists($file)) {
            continue;
        }
    
    Problem is [file_exists()](http://php.net/file_exists) returns false if link's target file doesn't exist. Therefore remove() will fail to delete a directory containing a broken link. Solution is to handle links a bit different:
    
        if (!file_exists($file) && !is_link($file)) {
            continue;
        }
    
    Additionally, this PR improves test coverage of Filesystem component.
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    
    ---------------------------------------------------------------------------
    
    by cordoval at 2012-04-07T00:55:59Z
    
    ✌.|•͡˘‿•͡˘|.✌
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-04-07T06:12:34Z
    
    Tests do not pass for me:
    
        PHPUnit 3.6.10 by Sebastian Bergmann.
    
        Configuration read from /Users/fabien/work/symfony/git/symfony/phpunit.xml.dist
    
        .........................EE.......
    
        Time: 0 seconds, Memory: 5.25Mb
    
        There were 2 errors:
    
        1) Symfony\Component\Filesystem\Tests\FilesystemTest::testMakePathRelative with data set #0 ('/var/lib/symfony/src/Symfony/', '/var/lib/symfony/src/Symfony/Component', '../')
        Uninitialized string offset: 29
    
        .../rc/Symfony/Component/Filesystem/Filesystem.php:183
        .../rc/Symfony/Component/Filesystem/Tests/FilesystemTest.php:434
    
        2) Symfony\Component\Filesystem\Tests\FilesystemTest::testMakePathRelative with data set #1 ('var/lib/symfony/', 'var/lib/symfony/src/Symfony/Component', '../../../')
        Uninitialized string offset: 16
    
        .../rc/Symfony/Component/Filesystem/Filesystem.php:183
        .../rc/Symfony/Component/Filesystem/Tests/FilesystemTest.php:434
    
        FAILURES!
        Tests: 34, Assertions: 67, Errors: 2.
    
    ---------------------------------------------------------------------------
    
    by jakzal at 2012-04-07T07:26:15Z
    
    Sorry for this. For some reason my PHP error reporting level was to low to catch this...
    
    Should be fixed now but I needed to modify the makePathRelative() (this bug existed before).
  10. merged branch eriksencosta/pt_BR-translations (PR #3817)

    fabpot committed Apr 7, 2012
    Commits
    -------
    
    bf51a58 [FrameworkBundle] fixed pt_BR translations (added commas to take a breath :)
    dc94e27 [FrameworkBundle] synced pt_BR translations
    
    Discussion
    ----------
    
    synced and fixed pt_BR translations
  11. fixed CS

    fabpot committed Apr 7, 2012
  12. merged branch eriksencosta/cs-fixes (PR #3816)

    fabpot committed Apr 7, 2012
    Commits
    -------
    
    abd59c3 Merge branch 'master' into cs-fixes
    f5f0506 [TwigBundle] fixed CS
    
    Discussion
    ----------
    
    CS fixes