Timing out today #2

Closed
boutell opened this Issue Jul 19, 2013 · 6 comments

Projects

None yet

2 participants

@boutell
boutell commented Jul 19, 2013

I've run the "mocha rest" tests in the tests folder with valid credentials, and it just hangs and eventually times out. I'm not finding any indications of problems on Twitter's end. But absolutely no love for mtwitter today. I wonder if they got stricter about something today?

@boutell
boutell commented Jul 19, 2013

Here's a data point: simple-twitter, a generally not as complete but distinct implementation of the twitter API also available in npm, is still working today. https://npmjs.org/package/simple-twitter

@passcod
Owner
passcod commented Jul 20, 2013

It works here. Does this still happen on your end?

@boutell
boutell commented Jul 20, 2013

Hmm, different results now. 3 tests pass, two fail:

  1. Using client auth should be able to perform a POST request
  2. Using client auth should be able to serialise the object itself

Same results on node 0.10.4 and node 0.8.16, two different boxes widely
separated on the Internet.

Both of these were just timing out yesterday though.

On Sat, Jul 20, 2013 at 4:07 AM, Félix Saparelli
notifications@github.comwrote:

It works here. Does this still happen on your end?


Reply to this email directly or view it on GitHubhttps://github.com/passcod/mtwitter/issues/2#issuecomment-21290032
.

Tom Boutell
P'unk Avenue
215 755 1330
punkave.com
window.punkave.com

@passcod
Owner
passcod commented Jul 20, 2013

If you go in the tests and increase or even remove the timeouts, it might help. I run the tests on "clean" credentials (so there's zero rate limits, zero interference from other apps), and from a fairly well-connected box, and I set timeouts mostly because otherwise Travis CI just timeouts the entire thing if one GET test takes a long time (and we want the rest of the results, too, right?).

The way mtwitter works, if it re-queues the requests they'll generally run minutes or more later, thus blowing out of the timeouts. Regarding other libraries:

  • If you care about getting the content, no matter what time it takes, that how mtwitter is designed. (It's not fully there yet, though.)
  • If you prefer to not get some content, and have the library get back to you (e.g. with an error) as soon as possible, you should either use other libraries, or specify the queue: false option.
@boutell
boutell commented Jul 20, 2013

It was timing out after a good long time on credentials not in use anywhere
else. I dunno. The tests that are still failing today are failing pretty
quickly ( a few seconds).

On Sat, Jul 20, 2013 at 9:31 AM, Félix Saparelli
notifications@github.comwrote:

If you go in the tests and increase or even remove the timeouts, it might
help. I run the tests on "clean" credentials (so there's zero rate limits,
zero interference from other apps), and from a fairly fast box, and I set
timeouts mostly because otherwise Travis CI just timeouts the entire thing
if one GET test takes a long time (and we want the rest of the results,
too, right?).

The way mtwitter works, if it re-queues the requests they'll generally run
minutes or more later, thus blowing out of the timeouts. Regarding
other libraries:

  • If you care about getting the content, no matter what time it takes,
    that how mtwitter is designed.
  • If you prefer to not get some content, and have the library get back
    to you (e.g. with an error) as soon as possible, you should either use
    other libraries, or specify the queue: false option.


Reply to this email directly or view it on GitHubhttps://github.com/passcod/mtwitter/issues/2#issuecomment-21293558
.

Tom Boutell
P'unk Avenue
215 755 1330
punkave.com
window.punkave.com

@passcod
Owner
passcod commented Jul 20, 2013

failing pretty quickly (a few seconds).

The timeouts are set to 10s per test, and here requests complete within about half that.

@passcod passcod closed this Oct 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment