New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw KMutableIterator.remove until implemented correctly #6

Merged
merged 1 commit into from Dec 2, 2018

Conversation

Projects
None yet
1 participant
@passsy
Owner

passsy commented Dec 2, 2018

Prevents #5 from returning wrong results

Throw KMutableIterator.remove until implemented correctly
Prevents #5 from returning wrong results
@codecov

This comment has been minimized.

codecov bot commented Dec 2, 2018

Codecov Report

Merging #6 into master will increase coverage by 1.33%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   50.88%   52.22%   +1.33%     
==========================================
  Files          30       30              
  Lines        1126     1126              
==========================================
+ Hits          573      588      +15     
+ Misses        553      538      -15
Impacted Files Coverage Δ
lib/src/collection/iterator.dart 50% <0%> (ø) ⬆️
lib/src/collection/set_mutable.dart 35% <0%> (ø) ⬆️
lib/src/extension/iterable_extension_mixin.dart 46.58% <0%> (+2.07%) ⬆️
lib/src/collection/map_empty.dart 78.94% <0%> (+5.26%) ⬆️
lib/src/extension/map_extensions_mixin.dart 100% <0%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3228e...04ae787. Read the comment docs.

@passsy passsy merged commit aebe09c into master Dec 2, 2018

2 of 3 checks passed

codecov/patch 0% of diff hit (target 50.88%)
Details
codecov/project 52.22% (+1.33%) compared to 8d99e2f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@passsy passsy deleted the feature/disable_iterator_remove_until_implemented branch Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment