Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pub publish: Remove analyzer exclusions #101

Merged
merged 9 commits into from Jun 11, 2019

Conversation

Projects
None yet
1 participant
@passsy
Copy link
Owner

commented Jun 11, 2019

This fix allows running pub publish with dart 2.2 and 2.3 again (see dart-lang/pub#2032)

Remove analyzer exclusions by applying fixes
This fix allows running pub publish with dart 2.2 and 2.3 again

@passsy passsy changed the title Remove analyzer exclusions by applying fixes Fix pub publish: Remove analyzer exclusions Jun 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codecov Report

Merging #101 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   99.53%   99.53%   -0.01%     
==========================================
  Files          42       42              
  Lines        1940     1937       -3     
==========================================
- Hits         1931     1928       -3     
  Misses          9        9
Impacted Files Coverage Δ
...collection/extension/iterable_extension_mixin.dart 99.3% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15044b8...761936d. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codecov Report

Merging #101 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   99.53%   99.53%   -0.01%     
==========================================
  Files          42       42              
  Lines        1940     1937       -3     
==========================================
- Hits         1931     1928       -3     
  Misses          9        9
Impacted Files Coverage Δ
...collection/extension/iterable_extension_mixin.dart 99.3% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15044b8...75dfd77. Read the comment docs.

@passsy passsy merged commit d9f2651 into master Jun 11, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 4156c01...75dfd77
Details
codecov/project 99.53% (-0.01%) compared to 4156c01
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@passsy passsy deleted the feature/fix_analyzer_in_non_lib branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.