Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embrace const where possible #103

Merged
merged 14 commits into from Jun 29, 2019

Conversation

Projects
None yet
1 participant
@passsy
Copy link
Owner

commented Jun 29, 2019

Use const where possible internally as well as for classes. New const constructors:

const KtPair("one", "two");
const KtTriple("one", "two", "three");
const IndexOutOfBoundsException("that was too far");
const NoSuchElementException("upsi");

Renamed KCollectionExtension to KtCollectionExtension

// Those const constructors aren't possible in dart 2.0 and dart 2.1, therefore not merged
const KtList.empty();
const KtSet.empty();
const KtMap.empty();
@codecov

This comment has been minimized.

Copy link

commented Jun 29, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@bab436f). Click here to learn what that means.
The diff coverage is 88%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #103   +/-   ##
=========================================
  Coverage          ?   99.37%           
=========================================
  Files             ?       42           
  Lines             ?     1927           
  Branches          ?        0           
=========================================
  Hits              ?     1915           
  Misses            ?       12           
  Partials          ?        0
Impacted Files Coverage Δ
lib/src/collection/kt_map.dart 100% <ø> (ø)
...llection/extension/collection_extension_mixin.dart 100% <ø> (ø)
...collection/extension/iterable_extension_mixin.dart 99.3% <ø> (ø)
lib/src/collection/kt_set.dart 100% <ø> (ø)
lib/src/collection/impl/iterator.dart 97.5% <100%> (ø)
lib/src/exception/exceptions.dart 100% <100%> (ø)
lib/src/collection/impl/set.dart 100% <100%> (ø)
...src/collection/extension/list_extension_mixin.dart 100% <100%> (ø)
lib/src/collection/collections.dart 100% <100%> (ø)
lib/src/collection/impl/map_empty.dart 100% <100%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab436f...782b55f. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jun 29, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@bab436f). Click here to learn what that means.
The diff coverage is 87.09%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #103   +/-   ##
=========================================
  Coverage          ?   99.37%           
=========================================
  Files             ?       42           
  Lines             ?     1926           
  Branches          ?        0           
=========================================
  Hits              ?     1914           
  Misses            ?       12           
  Partials          ?        0
Impacted Files Coverage Δ
lib/src/collection/kt_map.dart 100% <ø> (ø)
lib/src/util/arguments.dart 100% <ø> (ø)
...llection/extension/collection_extension_mixin.dart 100% <ø> (ø)
...collection/extension/iterable_extension_mixin.dart 99.3% <ø> (ø)
lib/src/collection/kt_set.dart 100% <ø> (ø)
lib/src/collection/impl/iterator.dart 97.5% <100%> (ø)
lib/src/exception/exceptions.dart 100% <100%> (ø)
lib/src/collection/impl/set.dart 100% <100%> (ø)
...src/collection/extension/list_extension_mixin.dart 100% <100%> (ø)
lib/src/collection/collections.dart 100% <100%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab436f...7ce5207. Read the comment docs.

passsy added some commits Jun 29, 2019

@passsy passsy merged commit 7370071 into master Jun 29, 2019

3 checks passed

codecov/patch 87.09% of diff hit (target 80%)
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@passsy passsy deleted the feature/cont_where_possible branch Jun 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.