New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DartSet DartMutableMap coverage #58

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
1 participant
@passsy
Copy link
Owner

passsy commented Jan 3, 2019

final kset = setOf(["a"]);
expect(kset, setOf(["a"]));
kset.set.add("b");
// kset is now unchanged, was changed before
expect(kset, setOf(["a"]));
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #58 into master will increase coverage by 1.73%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   97.45%   99.19%   +1.73%     
==========================================
  Files          25       25              
  Lines        1612     1612              
==========================================
+ Hits         1571     1599      +28     
+ Misses         41       13      -28
Impacted Files Coverage Δ
lib/src/collection/set.dart 100% <100%> (ø) ⬆️
lib/src/collections.dart 100% <0%> (ø) ⬆️
lib/src/collection/set_mutable.dart 94.66% <0%> (+10.66%) ⬆️
lib/src/collection/iterable.dart 100% <0%> (+14.28%) ⬆️
lib/src/collection/set_empty.dart 100% <0%> (+19.04%) ⬆️
lib/src/collection/map_empty.dart 100% <0%> (+21.05%) ⬆️
lib/src/collection/map.dart 97.61% <0%> (+23.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd0249...de97362. Read the comment docs.

@passsy passsy merged commit 4eefdef into master Jan 3, 2019

3 checks passed

codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 99.19% (+1.73%) compared to 6c0253a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@passsy passsy deleted the feature/bump_set_map_impl_coverage branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment