Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MDS3 #238

Merged
merged 4 commits into from Sep 13, 2021
Merged

Support MDS3 #238

merged 4 commits into from Sep 13, 2021

Conversation

aseigler
Copy link
Collaborator

@aseigler aseigler commented Sep 2, 2021

FIDO Metadata Service has received a significant upgrade recently, greatly reducing the complexity involved in utilizing the service. See https://medium.com/webauthnworks/webauthn-fido2-whats-new-in-mds3-migrating-from-mds2-to-mds3-a271d82cb774. Resolves #212.

All conformance tests are passing with the exception of the ones related to these issues:

fido-alliance/conformance-test-tools-resources#618
fido-alliance/conformance-test-tools-resources#619

@aseigler aseigler added enhancement Enhancements or general improvements feature New feature labels Sep 2, 2021
@dnfadmin
Copy link

dnfadmin commented Sep 2, 2021

CLA assistant check
All CLA requirements met.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@abergs
Copy link
Collaborator

abergs commented Sep 6, 2021

Not to self: I need to fix that label verification spam.

@abergs
Copy link
Collaborator

abergs commented Sep 6, 2021

Is there any breaking changes related to UserVerificationMethod?

@aseigler
Copy link
Collaborator Author

aseigler commented Sep 6, 2021

Is there any breaking changes related to UserVerificationMethod?

No change to the extension, but as mentioned in the referenced article, numerical fields got changed to strings:

WAS: "userVerificationDetails": [[{ "userVerification": 2 }]]

NOW: "userVerificationDetails": [[{ "userVerificationMethod": "fingerprint_internal" }]]

@aseigler aseigler merged commit f0156a3 into master Sep 13, 2021
@aseigler aseigler deleted the MDS3 branch September 13, 2021 22:36
@abergs abergs mentioned this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements or general improvements feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDS3 Transition
3 participants