New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate profiles automatically for specific sites #34

Merged
merged 3 commits into from Aug 3, 2011

Conversation

Projects
None yet
2 participants
@wadetb
Contributor

wadetb commented Jul 27, 2011

This is like the patch that matches sites to profile names, but adds a "Use with sites" field to the profile option instead of using the profile name.

I think this is a little better as it's discoverable, is off by default, allows assigning more than one site to a profile, and doesn't change the setting permanently when it activates.

Allow profiles to activate automatically for specific sites, via a "u…
…se with sites" list in profile options.

This is useful when sites implement a "change password every N days" policy.  Or, when sites have different password requirements like "no punctuation".

Simply add those sites to a different profile and forget about them.

Automatic activation is not persistent, to not interfere with normal usage.
@bitboxer

This comment has been minimized.

Show comment
Hide comment
@bitboxer

bitboxer Jul 27, 2011

Contributor

Yes, this sounds better. Do you know if the rdf that the firefox extension is exporting has the site-profile-setting in it? If yes, the importer could read that and add that to the profile in this extension...

Contributor

bitboxer commented Jul 27, 2011

Yes, this sounds better. Do you know if the rdf that the firefox extension is exporting has the site-profile-setting in it? If yes, the importer could read that and add that to the profile in this extension...

@wadetb

This comment has been minimized.

Show comment
Hide comment
@wadetb

wadetb Jul 28, 2011

Contributor

I'm not sure, never used PasswordMaker w/Firefox so I didn't know it has a similar feature. I'll try FF out tomorrow and see if it exports a site list per profile.

Contributor

wadetb commented Jul 28, 2011

I'm not sure, never used PasswordMaker w/Firefox so I didn't know it has a similar feature. I'll try FF out tomorrow and see if it exports a site list per profile.

@wadetb wadetb closed this Jul 28, 2011

@wadetb wadetb reopened this Jul 28, 2011

@wadetb

This comment has been minimized.

Show comment
Hide comment
@wadetb

wadetb Jul 28, 2011

Contributor

Oh no, I didn't realize thats what "Comment and Close" meant. I thought it meant the window. Ha

Contributor

wadetb commented Jul 28, 2011

Oh no, I didn't realize thats what "Comment and Close" meant. I thought it meant the window. Ha

@wadetb

This comment has been minimized.

Show comment
Hide comment
@wadetb

wadetb Jul 28, 2011

Contributor

Yes, the RDF exporter does export this information. There is a conflict between my implementation and FF's however:

FF PasswordMaker supports wildcard or regex patterns against the complete URL.
My extension supports exact matches against the "used text".

My plan is to import FF regex as '/foo/' and FF wildcard as 'foo', continuing to use space as the delimiter. I will change my extension to successfully match profiles against either entire URL or "used text". I could remove "used text" matching but I feel it is more convenient.

Contributor

wadetb commented Jul 28, 2011

Yes, the RDF exporter does export this information. There is a conflict between my implementation and FF's however:

FF PasswordMaker supports wildcard or regex patterns against the complete URL.
My extension supports exact matches against the "used text".

My plan is to import FF regex as '/foo/' and FF wildcard as 'foo', continuing to use space as the delimiter. I will change my extension to successfully match profiles against either entire URL or "used text". I could remove "used text" matching but I feel it is more convenient.

@bitboxer

This comment has been minimized.

Show comment
Hide comment
@bitboxer

bitboxer Jul 28, 2011

Contributor

Sounds great.

Contributor

bitboxer commented Jul 28, 2011

Sounds great.

Add wildcard and regex support to 'use with sites' option. Regex must…
… be enclosed in //, e.g. /https?.*/.


Add RDF import of site list strings.
@wadetb

This comment has been minimized.

Show comment
Hide comment
@wadetb

wadetb Jul 28, 2011

Contributor

This should be gtg.

Contributor

wadetb commented Jul 28, 2011

This should be gtg.

@bitboxer

This comment has been minimized.

Show comment
Hide comment
@bitboxer

bitboxer Jul 29, 2011

Contributor

Can you add the tests for the import script for this?

Contributor

bitboxer commented Jul 29, 2011

Can you add the tests for the import script for this?

bitboxer added a commit that referenced this pull request Aug 3, 2011

Merge pull request #34 from wadetb/match-profile-to-site
Activate profiles automatically for specific sites

@bitboxer bitboxer merged commit f44a003 into passwordmaker:master Aug 3, 2011

@bitboxer

This comment has been minimized.

Show comment
Hide comment
@bitboxer

bitboxer Aug 3, 2011

Contributor

I now played a little bit with it, but there is one little problem:

when I have a text like "test.com" in the use with sites field and surf on mytest.com, it also matches, right? I don't think that this is a wanted behaviour?

Contributor

bitboxer commented Aug 3, 2011

I now played a little bit with it, but there is one little problem:

when I have a text like "test.com" in the use with sites field and surf on mytest.com, it also matches, right? I don't think that this is a wanted behaviour?

@wadetb

This comment has been minimized.

Show comment
Hide comment
@wadetb

wadetb Aug 4, 2011

Contributor

The regex is surrounded with ^ and $ automatically, so it should match the entire string - not a subset. I just tested with test.com and mytest.com and it works as expected....AFTER a bug fix which I just pushed, I'm not sure how I let that slip past :)

Contributor

wadetb commented Aug 4, 2011

The regex is surrounded with ^ and $ automatically, so it should match the entire string - not a subset. I just tested with test.com and mytest.com and it works as expected....AFTER a bug fix which I just pushed, I'm not sure how I let that slip past :)

@bitboxer

This comment has been minimized.

Show comment
Hide comment
@bitboxer

bitboxer Aug 4, 2011

Contributor

Okay, make a pull request and I will pull it in. After that I will test it a little bit and then release the new version hopefully tomorrow.

Contributor

bitboxer commented Aug 4, 2011

Okay, make a pull request and I will pull it in. After that I will test it a little bit and then release the new version hopefully tomorrow.

@bitboxer

This comment has been minimized.

Show comment
Hide comment
@bitboxer

bitboxer Aug 4, 2011

Contributor

Thanks for this!

Contributor

bitboxer commented Aug 4, 2011

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment