Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen (or bump) dependency on rubocop? #104

Closed
utkarsh2102 opened this issue Apr 17, 2020 · 2 comments
Closed

Loosen (or bump) dependency on rubocop? #104

utkarsh2102 opened this issue Apr 17, 2020 · 2 comments

Comments

@utkarsh2102
Copy link
Contributor

Hi @pat,

Thanks for your awesome work on this so far.

combustion/combustion.gemspec

Line 30 in 309e9f7

s.add_development_dependency "rubocop", "~> 0.79.0"

Whilst maintaining this library in Debian, it fails to build since the version in the Debian archive is 0.80.1. We'd need to patch this, can this be done here, too?

Also, irrespective of this, can you please make a new release, too? :)
@pat
Copy link
Owner

pat commented Apr 18, 2020

Just updated and relaxed the dependency, and published v1.2.0 :) Thanks for the prod!

@pat pat closed this as completed Apr 18, 2020
@utkarsh2102
Copy link
Contributor Author

You're awesome! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pat @utkarsh2102