Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Rails 4.1 #2

Closed
wants to merge 1 commit into from
Closed

Conversation

DarthSim
Copy link
Contributor

This PR adds compatibility with Rails 4.1. Unfortunately it also breaks compatibility with older versions of Rails. Hope this is what you need to make Thinking Sphinx work with 4.1.
Note: Rails 4 doesn't support :condition option for associations so I had to remove this functionality from joiner.

@DarthSim DarthSim changed the title Rails41 Compatibility with Rails 4.1 Apr 15, 2014
@pat
Copy link
Owner

pat commented Apr 15, 2014

Thanks for this, it's greatly appreciated! I'll try to kick the tires and see how we go over the next few days.

When you have a spare moment, would you be able to remove Pry references (in the gemspec and the .pryrc file) and squash the commits?

@pat
Copy link
Owner

pat commented Apr 15, 2014

And yes: having it work with only Rails 4.1 is fine - my goal is to keep the interface static, so different joiner gem versions can support different Rails versions, and Thinking Sphinx doesn't need to care about which version of joiner is being used.

Hence, the existing release of joiner that supports Rails 4.0 and 3.2 covers those options.

@DarthSim
Copy link
Contributor Author

When you have a spare moment, would you be able to remove Pry references (in the gemspec and the .pryrc file) and squash the commits?

Done

And yes: having it work with only Rails 4.1 is fine - my goal is to keep the interface static, so different joiner gem versions can support different Rails versions, and Thinking Sphinx doesn't need to care about which version of joiner is being used.

I thought so :)

@pat
Copy link
Owner

pat commented Apr 15, 2014

Appreciate the quick turnaround. I should have time this weekend to get this reviewed, merged, and a new version out! /cc @atipugin

@pat
Copy link
Owner

pat commented Apr 19, 2014

Just merged this into master and released 0.3.0 - many thanks for all of your hard work!

@pat pat closed this Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants